netdev - Re: [PATCH net-next 00/13] net: dsa: realtek: MDIO interface and RTL8367S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbxXt/qQ5CudjkX6@lunn.ch>
Date:   Fri, 17 Dec 2021 10:26:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linus.walleij@...aro.org, vivien.didelot@...il.com,
        Florian Fainelli <f.fainelli@...il.com>, olteanv@...il.com,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Arınç ÜNAL <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 00/13] net: dsa: realtek: MDIO interface and
 RTL8367S

On Fri, Dec 17, 2021 at 05:53:49AM -0300, Luiz Angelo Daros de Luca wrote:
> > On Thu, 16 Dec 2021 17:13:29 -0300 luizluca@...il.com wrote:
> > > This series refactors the current Realtek DSA driver to support MDIO
> > > connected switchesand RTL8367S. RTL8367S is a 5+2 10/100/1000M Ethernet
> > > switch, with one of those 2 external ports supporting SGMII/High-SGMII.
> >
> > nit: plenty of warnings in patch 3 and patch 8, please try building
> > patch-by-patch with C=1 and W=1. Also some checkpatch warnings that
> > should be fixed (scripts/checkpatch.pl).
> 
> Yes, I got those problems fixed. I'll resend as soon as the
> rtl8365mb/rtl8367c name discussion settles.
> Or should I already send the patches before that one?
> 
> For now, here is my repo:
> https://github.com/luizluca/linux/commits/realtek_mdio_refactor

Please give people time to comment on the patches. Don't do a resend
in less than 24 hours. It is really annoying to do a review on v1 and
then find lower down in your mailbox v2. Also, comments made to v1
sometimes get lost and never make it into v3.

	  Andrew