netdev - Re: [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211222170932.1773d408@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 22 Dec 2021 17:09:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Roi Dayan <roid@...dia.com>, Miaoqian Lin <linmq006@...il.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in
 dr_domain_init_resources

On Wed, 22 Dec 2021 17:04:03 -0800 Jakub Kicinski wrote:
> On Wed, 22 Dec 2021 13:11:51 -0800 Saeed Mahameed wrote:
> > From: Miaoqian Lin <linmq006@...il.com>
> > 
> > The mlx5_get_uars_page() function  returns error pointers.
> > Using IS_ERR() to check the return value to fix this.
> > 
> > Fixes: 4ec9e7b02697("net/mlx5: DR, Expose steering domain functionality")  
> 
> Do you mind fixing this missing space? I'll cherry pick the change from
> net-next in the meantime.

I take that back, I thought the error was on our side but looks like
the patch was put in the wrong PR. Why not put it in the net PR
yourself? We'll handle the unavoidable conflict, but I don't see any
advantage to me cherry picking here (which I can't do directly anyway,
TBH, my local trees have only one remote to avoid false negative Fixes
tag checks).