netdev - Re: [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaa0dfacd5df9ac76469575ddb8bbbcfae21ad25.camel@kernel.org>
Date:   Wed, 22 Dec 2021 20:28:16 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Roi Dayan <roid@...dia.com>, Miaoqian Lin <linmq006@...il.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in
 dr_domain_init_resources

On Wed, 2021-12-22 at 17:09 -0800, Jakub Kicinski wrote:
> On Wed, 22 Dec 2021 17:04:03 -0800 Jakub Kicinski wrote:
> > On Wed, 22 Dec 2021 13:11:51 -0800 Saeed Mahameed wrote:
> > > From: Miaoqian Lin <linmq006@...il.com>
> > > 
> > > The mlx5_get_uars_page() function  returns error pointers.
> > > Using IS_ERR() to check the return value to fix this.
> > > 
> > > Fixes: 4ec9e7b02697("net/mlx5: DR, Expose steering domain
> > > functionality")  
> > 
> > Do you mind fixing this missing space? I'll cherry pick the change
> > from

Sure, I will submit v2.

> > net-next in the meantime.
> 
> I take that back, I thought the error was on our side but looks like
> the patch was put in the wrong PR. Why not put it in the net PR

Yes, my mistake, the bug only existed in net-next when I accepted the
patch, I mistakenly left it in my net-next tree after rc1 was out.

> yourself? We'll handle the unavoidable conflict, but I don't see any
> advantage to me cherry picking here (which I can't do directly
> anyway,

This how I remember we used to do it.
Sure i will attach it in v2. I already checked, there will be no
conflicts.