netdev - [PATCH net-next v2 1/1] qed: add prints if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211227175656.267184-1-vbhavaraju@marvell.com>
Date:   Mon, 27 Dec 2021 09:56:56 -0800
From:   Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
To:     <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>,
        Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>,
        Ariel Elior <aelior@...vell.com>,
        Alok Prasad <palok@...vell.com>
Subject: [PATCH net-next v2 1/1] qed: add prints if request_firmware() failed

If driver load failed due to request_firmware() not finding the device
firmware file, add prints that help remedy the situation.

Signed-off-by: Ariel Elior <aelior@...vell.com>
Signed-off-by: Alok Prasad <palok@...vell.com>
Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
---
Changes in v2:
 - Rename QED_FW_REPO to FW_REPO
 - Move FW_REPO macro to qed_if.h
---
 drivers/net/ethernet/qlogic/qed/qed_main.c | 3 +++
 include/linux/qed/qed_if.h                 | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index 46d4207f22a3..845c151c5def 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -1285,6 +1285,9 @@ static int qed_slowpath_start(struct qed_dev *cdev,
 			DP_NOTICE(cdev,
 				  "Failed to find fw file - /lib/firmware/%s\n",
 				  QED_FW_FILE_NAME);
+			DP_NOTICE(cdev,
+				  "you may need to download firmware from %s",
+				  FW_REPO);
 			goto err;
 		}
 
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index 6dc4943d8aec..f063d82ef8f9 100644
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -1210,6 +1210,9 @@ struct qed_common_ops {
 	int (*get_esl_status)(struct qed_dev *cdev, bool *esl_active);
 };
 
+#define FW_REPO		\
+	"https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
+
 #define MASK_FIELD(_name, _value) \
 	((_value) &= (_name ## _MASK))
 
-- 
2.27.0