netdev - Re: [PATCH net-next v2 1/1] qed: add prints if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcrmpvMAD5zKHqTE@lunn.ch>
Date:   Tue, 28 Dec 2021 11:27:50 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
Cc:     netdev@...r.kernel.org, Ariel Elior <aelior@...vell.com>,
        Alok Prasad <palok@...vell.com>
Subject: Re: [PATCH net-next v2 1/1] qed: add prints if request_firmware()
 failed

On Mon, Dec 27, 2021 at 09:56:56AM -0800, Venkata Sudheer Kumar Bhavaraju wrote:
> If driver load failed due to request_firmware() not finding the device
> firmware file, add prints that help remedy the situation.
> 
> Signed-off-by: Ariel Elior <aelior@...vell.com>
> Signed-off-by: Alok Prasad <palok@...vell.com>
> Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
> ---
> Changes in v2:
>  - Rename QED_FW_REPO to FW_REPO
>  - Move FW_REPO macro to qed_if.h

Hi Venkata

When you decide to do something different to what has been requested,
it is a good idea to say why. There might be a very good reason for
this, but unless you explain it, i have no idea what it is.

   Andrew