netdev - Re: [PATCH net-next v2 1/1] qed: add prints if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211229110232.336845-1-vbhavaraju@marvell.com>
Date:   Wed, 29 Dec 2021 03:02:32 -0800
From:   Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
To:     <andrew@...n.ch>
CC:     <aelior@...vell.com>, <netdev@...r.kernel.org>,
        <palok@...vell.com>, <vbhavaraju@...vell.com>
Subject: Re: [PATCH net-next v2 1/1] qed: add prints if request_firmware() failed

> Hi Venkata
> 
> When you decide to do something different to what has been requested,
> it is a good idea to say why. There might be a very good reason for
> this, but unless you explain it, i have no idea what it is.
> 
>    Andrew

Hello Andrew,

I moved the FW_REPO macro to qed_if.h under include/linux since I didn't
want to bloat something like include/linux/firmware.h. It's really used
(exact URL in a print after request_firmware() fails) at two other places.

If you think it's more useful in include/linux/firmware.h so that other
drivers can make use of it in future, I can move it there.

-Venkata