netdev - Re: [PATCH net-next v2 1/1] qed: add prints if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211229111349.15f28b34@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 29 Dec 2021 11:13:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
Cc:     <andrew@...n.ch>, <aelior@...vell.com>, <netdev@...r.kernel.org>,
        <palok@...vell.com>
Subject: Re: [PATCH net-next v2 1/1] qed: add prints if request_firmware()
 failed

On Wed, 29 Dec 2021 03:02:32 -0800 Venkata Sudheer Kumar Bhavaraju
wrote:
> > Hi Venkata
> > 
> > When you decide to do something different to what has been requested,
> > it is a good idea to say why. There might be a very good reason for
> > this, but unless you explain it, i have no idea what it is.
> 
> I moved the FW_REPO macro to qed_if.h under include/linux since I didn't
> want to bloat something like include/linux/firmware.h. It's really used
> (exact URL in a print after request_firmware() fails) at two other places.
> 
> If you think it's more useful in include/linux/firmware.h so that other
> drivers can make use of it in future, I can move it there.

If printing this information made sense it should have been done by the
core, not each driver. In fact your existing print:

 			DP_NOTICE(cdev,
 				  "Failed to find fw file - /lib/firmware/%s\n",
 				  QED_FW_FILE_NAME);

is redundant and potentially incorrect. Firmware path is configurable,
it does not have to be /lib/firmware. request_firmware() does not set
FW_OPT_NO_WARN, so core will already print the warning.

As for your current patch vast majority of users will get the firmware
from distro packages. I don't know why you're trying to print the repo
link.