netdev - Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a82690c-7dc0-81de-4dd6-06e26e4b9b92@gmail.com>
Date:   Tue, 28 Dec 2021 17:33:39 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, ast@...nel.org,
        daniel@...earbox.net
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Marc Kleine-Budde <mkl@...gutronix.de>, marcel@...tmann.org,
        johan.hedberg@...il.com, luiz.dentz@...il.com, dledford@...hat.com,
        jgg@...pe.ca, mustafa.ismail@...el.com, shiraz.saleem@...el.com,
        leon@...nel.org, ap420073@...il.com, wg@...ndegger.com,
        woojung.huh@...rochip.com, andrew@...n.ch,
        vivien.didelot@...il.com, olteanv@...il.com,
        george.mccollister@...il.com, michael.chan@...adcom.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        hawk@...nel.org, john.fastabend@...il.com, tariqt@...dia.com,
        saeedm@...dia.com, ecree.xilinx@...il.com,
        habetsm.xilinx@...il.com, jreuter@...na.de, dsahern@...nel.org,
        kvalo@...eaurora.org, pkshih@...ltek.com,
        trond.myklebust@...merspace.com, anna.schumaker@...app.com,
        viro@...iv.linux.org.uk, andrii@...nel.org, mcgrof@...nel.org,
        keescook@...omium.org, yzaikin@...gle.com, nikolay@...dia.com,
        jiri@...dia.com, wintera@...ux.ibm.com, wenjia@...ux.ibm.com,
        pablo@...filter.org, kadlec@...filter.org, fw@...len.de,
        ralf@...ux-mips.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        kgraul@...ux.ibm.com, sgarzare@...hat.com,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        arnd@...db.de, linux-bluetooth@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-can@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, linux-hams@...r.kernel.org,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        bridge@...ts.linux-foundation.org,
        linux-decnet-user@...ts.sourceforge.net,
        linux-s390@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h



On 12/28/2021 4:49 PM, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
> 
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
> 
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

It would be nice if we used the number of files rebuilt because of a 
header file change as another metric that the kernel is evaluated with 
from release to release (or even on a commit by commit basis). Food for 
thought.
-- 
Florian