netdev - Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <081437ff-a69d-faf5-0981-389156a90668@nvidia.com>
Date:   Wed, 29 Dec 2021 13:46:14 +0200
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>, <ast@...nel.org>,
        <daniel@...earbox.net>
CC:     <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>, <marcel@...tmann.org>,
        <johan.hedberg@...il.com>, <luiz.dentz@...il.com>,
        <dledford@...hat.com>, <jgg@...pe.ca>, <mustafa.ismail@...el.com>,
        <shiraz.saleem@...el.com>, <leon@...nel.org>, <ap420073@...il.com>,
        <wg@...ndegger.com>, <woojung.huh@...rochip.com>, <andrew@...n.ch>,
        <vivien.didelot@...il.com>, <f.fainelli@...il.com>,
        <olteanv@...il.com>, <george.mccollister@...il.com>,
        <michael.chan@...adcom.com>, <jesse.brandeburg@...el.com>,
        <anthony.l.nguyen@...el.com>, <hawk@...nel.org>,
        <john.fastabend@...il.com>, <tariqt@...dia.com>,
        <saeedm@...dia.com>, <ecree.xilinx@...il.com>,
        <habetsm.xilinx@...il.com>, <jreuter@...na.de>,
        <dsahern@...nel.org>, <kvalo@...eaurora.org>, <pkshih@...ltek.com>,
        <trond.myklebust@...merspace.com>, <anna.schumaker@...app.com>,
        <viro@...iv.linux.org.uk>, <andrii@...nel.org>,
        <mcgrof@...nel.org>, <keescook@...omium.org>, <yzaikin@...gle.com>,
        <jiri@...dia.com>, <wintera@...ux.ibm.com>, <wenjia@...ux.ibm.com>,
        <pablo@...filter.org>, <kadlec@...filter.org>, <fw@...len.de>,
        <ralf@...ux-mips.org>, <jhs@...atatu.com>,
        <xiyou.wangcong@...il.com>, <kgraul@...ux.ibm.com>,
        <sgarzare@...hat.com>, <steffen.klassert@...unet.com>,
        <herbert@...dor.apana.org.au>, <arnd@...db.de>,
        <linux-bluetooth@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <linux-can@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
        <linux-hams@...r.kernel.org>, <ath11k@...ts.infradead.org>,
        <linux-wireless@...r.kernel.org>, <linux-nfs@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>,
        <bridge@...ts.linux-foundation.org>,
        <linux-decnet-user@...ts.sourceforge.net>,
        <linux-s390@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
        <coreteam@...filter.org>,
        <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h

On 29/12/2021 02:49, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
> 
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
> 
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/
>  - fix build in bond on ia64
>  - fix build in ip6_fib with randconfig
> 
> CC: marcel@...tmann.org
> CC: johan.hedberg@...il.com
> CC: luiz.dentz@...il.com
> CC: dledford@...hat.com
> CC: jgg@...pe.ca
> CC: mustafa.ismail@...el.com
> CC: shiraz.saleem@...el.com
> CC: leon@...nel.org
> CC: ap420073@...il.com
> CC: wg@...ndegger.com
> CC: woojung.huh@...rochip.com
> CC: andrew@...n.ch
> CC: vivien.didelot@...il.com
> CC: f.fainelli@...il.com
> CC: olteanv@...il.com
> CC: george.mccollister@...il.com
> CC: michael.chan@...adcom.com
> CC: jesse.brandeburg@...el.com
> CC: anthony.l.nguyen@...el.com
> CC: ast@...nel.org
> CC: daniel@...earbox.net
> CC: hawk@...nel.org
> CC: john.fastabend@...il.com
> CC: tariqt@...dia.com
> CC: saeedm@...dia.com
> CC: ecree.xilinx@...il.com
> CC: habetsm.xilinx@...il.com
> CC: jreuter@...na.de
> CC: dsahern@...nel.org
> CC: kvalo@...eaurora.org
> CC: pkshih@...ltek.com
> CC: trond.myklebust@...merspace.com
> CC: anna.schumaker@...app.com
> CC: viro@...iv.linux.org.uk
> CC: andrii@...nel.org
> CC: mcgrof@...nel.org
> CC: keescook@...omium.org
> CC: yzaikin@...gle.com
> CC: nikolay@...dia.com
> CC: jiri@...dia.com
> CC: wintera@...ux.ibm.com
> CC: wenjia@...ux.ibm.com
> CC: pablo@...filter.org
> CC: kadlec@...filter.org
> CC: fw@...len.de
> CC: ralf@...ux-mips.org
> CC: jhs@...atatu.com
> CC: xiyou.wangcong@...il.com
> CC: kgraul@...ux.ibm.com
> CC: sgarzare@...hat.com
> CC: steffen.klassert@...unet.com
> CC: herbert@...dor.apana.org.au
> CC: arnd@...db.de
> CC: linux-bluetooth@...r.kernel.org
> CC: linux-rdma@...r.kernel.org
> CC: linux-can@...r.kernel.org
> CC: intel-wired-lan@...ts.osuosl.org
> CC: bpf@...r.kernel.org
> CC: linux-hams@...r.kernel.org
> CC: ath11k@...ts.infradead.org
> CC: linux-wireless@...r.kernel.org
> CC: linux-nfs@...r.kernel.org
> CC: linux-fsdevel@...r.kernel.org
> CC: bridge@...ts.linux-foundation.org
> CC: linux-decnet-user@...ts.sourceforge.net
> CC: linux-s390@...r.kernel.org
> CC: netfilter-devel@...r.kernel.org
> CC: coreteam@...filter.org
> CC: virtualization@...ts.linux-foundation.org
> ---
[snip]
>  net/bridge/br_ioctl.c                             | 1 +
[snip
>  70 files changed, 80 insertions(+), 1 deletion(-)
> 

For the bridge:
Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>