netdev - Re: [PATCH net-next 11/13] netlink: add net device refcount tracker to struct ethnl_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c14b5872799b071145c79a78aab238884510f2a9.camel@sipsolutions.net>
Date:   Tue, 04 Jan 2022 17:07:30 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 11/13] netlink: add net device refcount tracker
 to struct ethnl_req_info

Hi Eric,

> > > @@ -624,6 +625,7 @@ static void ethnl_default_notify(struct net_device *dev, unsigned int cmd,
> > >       }
> > > 
> > >       req_info->dev = dev;
> > > +     netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
> > >       req_info->flags |= ETHTOOL_FLAG_COMPACT_BITSETS;
> > > 
> > 
> > I may have missed a follow-up patch (did a search on netdev now, but
> > ...), but I'm hitting warnings from this and I'm not sure it's right?
> > 
> > This req_info is just allocated briefly and freed again, and I'm not
> > even sure there's a dev_get/dev_put involved here, I didn't see any?
> 
> We had a fix.
> 
> commit 34ac17ecbf575eb079094d44f1bd30c66897aa21
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Tue Dec 14 00:42:30 2021 -0800
> 
>     ethtool: use ethnl_parse_header_dev_put()
> 

Hmm. I have this in my tree, and I don't think it affected
ethnl_default_notify() anyway?

johannes