netdev - Re: [PATCH bpf-next v2 1/2] net: add includes masked by netdevice.h including uapi/bpf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 13:03:37 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     ast@...nel.org, daniel@...earbox.net, bpf@...r.kernel.org,
        netdev@...r.kernel.org, shayagr@...zon.com, akiyano@...zon.com,
        darinzon@...zon.com, ndagan@...zon.com, saeedb@...zon.com,
        sgoutham@...vell.com, kys@...rosoft.com, haiyangz@...rosoft.com,
        sthemmin@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        grygorii.strashko@...com, sameehj@...zon.com,
        chenhao288@...ilicon.com, moyufeng@...wei.com,
        linux-arm-kernel@...ts.infradead.org, linux-hyperv@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 1/2] net: add includes masked by netdevice.h
 including uapi/bpf.h

On Wed, Dec 29, 2021 at 05:27:41PM -0800, Jakub Kicinski wrote:
> Add missing includes unmasked by the subsequent change.
> 
> Mostly network drivers missing an include for XDP_PACKET_HEADROOM.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
[...]
>  drivers/net/ethernet/microsoft/mana/mana_en.c      | 2 ++

This seems trivially correct, so in case an ack is needed:

Acked-by: Wei Liu <wei.liu@...nel.org>

> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index c1d5a374b967..2ece9e90dc50 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
>  /* Copyright (c) 2021, Microsoft Corporation. */
>  
> +#include <uapi/linux/bpf.h>
> +
>  #include <linux/inetdevice.h>
>  #include <linux/etherdevice.h>
>  #include <linux/ethtool.h>