netdev - Re: [PATCH CFT net-next] net: enetc: use .mac_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdhDAHxFaUhiQFbd@shell.armlinux.org.uk>
Date:   Fri, 7 Jan 2022 13:41:20 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Claudiu Manoil <claudiu.manoil@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH CFT net-next] net: enetc: use .mac_select_pcs() interface

On Thu, Dec 16, 2021 at 12:41:41PM +0000, Russell King (Oracle) wrote:
> Convert the PCS selection to use mac_select_pcs, which allows the PCS
> to perform any validation it needs.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Hi,

Can anyone test this please? Claudiu?

Russell.

> ---
>  drivers/net/ethernet/freescale/enetc/enetc_pf.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> index fe6a544f37f0..1f5bc8fe0a3c 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> @@ -930,18 +930,21 @@ static void enetc_mdiobus_destroy(struct enetc_pf *pf)
>  	enetc_imdio_remove(pf);
>  }
>  
> +static struct phylink_pcs *
> +enetc_pl_mac_select_pcs(struct phylink_config *config, phy_interface_t iface)
> +{
> +	struct enetc_pf *pf = phylink_to_enetc_pf(config);
> +
> +	return pf->pcs ? &pf->pcs->pcs : NULL;
> +}
> +
>  static void enetc_pl_mac_config(struct phylink_config *config,
>  				unsigned int mode,
>  				const struct phylink_link_state *state)
>  {
>  	struct enetc_pf *pf = phylink_to_enetc_pf(config);
> -	struct enetc_ndev_priv *priv;
>  
>  	enetc_mac_config(&pf->si->hw, state->interface);
> -
> -	priv = netdev_priv(pf->si->ndev);
> -	if (pf->pcs)
> -		phylink_set_pcs(priv->phylink, &pf->pcs->pcs);
>  }
>  
>  static void enetc_force_rgmii_mac(struct enetc_hw *hw, int speed, int duplex)
> @@ -1058,6 +1061,7 @@ static void enetc_pl_mac_link_down(struct phylink_config *config,
>  
>  static const struct phylink_mac_ops enetc_mac_phylink_ops = {
>  	.validate = phylink_generic_validate,
> +	.mac_select_pcs = enetc_pl_mac_select_pcs,
>  	.mac_config = enetc_pl_mac_config,
>  	.mac_link_up = enetc_pl_mac_link_up,
>  	.mac_link_down = enetc_pl_mac_link_down,
> -- 
> 2.30.2
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!