netdev - RE: [PATCH CFT net-next] net: enetc: use .mac_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB83977DD63CD3DB191E79DC7D96509@AM9PR04MB8397.eurprd04.prod.outlook.com>
Date:   Mon, 10 Jan 2022 17:37:55 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH CFT net-next] net: enetc: use .mac_select_pcs() interface

> -----Original Message-----
> From: Russell King <linux@...linux.org.uk>
> Sent: Friday, January 7, 2022 3:41 PM
> To: David S. Miller <davem@...emloft.net>; Jakub Kicinski
> <kuba@...nel.org>
> Cc: Claudiu Manoil <claudiu.manoil@....com>; netdev@...r.kernel.org
> Subject: Re: [PATCH CFT net-next] net: enetc: use .mac_select_pcs()
> interface
> 
> On Thu, Dec 16, 2021 at 12:41:41PM +0000, Russell King (Oracle) wrote:
> > Convert the PCS selection to use mac_select_pcs, which allows the PCS
> > to perform any validation it needs.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> 
> Hi,
> 
> Can anyone test this please? Claudiu?
> 
> Russell.
> 

Hi Russell,

drivers/net/ethernet/freescale/enetc/enetc_pf.c: In function 'enetc_pl_mac_select_pcs':
drivers/net/ethernet/freescale/enetc/enetc_pf.c:942:27: error: 'struct phylink_pcs' has no member named 'pcs'
  942 |  return pf->pcs ? &pf->pcs->pcs : NULL;

I suppose you meant:
-       return pf->pcs ? &pf->pcs->pcs : NULL;
+       return pf->pcs;

With this correction I could bring up the SGMII link on my ls1028rdb.
The patch needs also rebase.

Thanks.
Claudiu