netdev - RE: [PATCH net-next v1] mlxbf_gige: add interrupt counts to "ethtool -S"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR12MB553445B69CEA2675BAA69EF8C74D9@DM6PR12MB5534.namprd12.prod.outlook.com>
Date:   Fri, 7 Jan 2022 17:41:58 +0000
From:   David Thompson <davthompson@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "chenhao288@...ilicon.com" <chenhao288@...ilicon.com>,
        Asmaa Mnebhi <asmaa@...dia.com>
Subject: RE: [PATCH net-next v1] mlxbf_gige: add interrupt counts to "ethtool
 -S"

Thanks for the review Jakub.  Will look into removing the counters.

- Dave

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, January 6, 2022 10:05 PM
> To: David Thompson <davthompson@...dia.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org;
> chenhao288@...ilicon.com; Asmaa Mnebhi <asmaa@...dia.com>
> Subject: Re: [PATCH net-next v1] mlxbf_gige: add interrupt counts to "ethtool -
> S"
> 
> On Thu, 6 Jan 2022 12:29:10 -0500 David Thompson wrote:
> > This patch extends the output of "ethtool -S", adding interrupt counts
> > for the three mlxbf_gige interrupt types.
> 
> Why? These count separate, non-shared interrupts. You get the same stats from
> /proc/interrupts with per-cpu break down.
> 
> Since core already has this information rather than reporting those via ethtool
> you should remove the counters from the driver.