netdev - Re: [PATCH net-next v1] mlxbf_gige: add interrupt counts to "ethtool -S"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220106190516.147e9e32@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 6 Jan 2022 19:05:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Thompson <davthompson@...dia.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <chenhao288@...ilicon.com>, Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net-next v1] mlxbf_gige: add interrupt counts to
 "ethtool -S"

On Thu, 6 Jan 2022 12:29:10 -0500 David Thompson wrote:
> This patch extends the output of "ethtool -S", adding
> interrupt counts for the three mlxbf_gige interrupt types.

Why? These count separate, non-shared interrupts. You get the same
stats from /proc/interrupts with per-cpu break down.

Since core already has this information rather than reporting those
via ethtool you should remove the counters from the driver.