netdev - Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto setting in sec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 16:47:26 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     Raed Salem <raeds@...dia.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, kuba@...nel.org, huyn@...dia.com,
        saeedm@...dia.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto
 setting in sec_path

On Thu, Jan 06, 2022 at 10:32:23AM +0100, Steffen Klassert wrote:
>On Mon, Jan 03, 2022 at 01:19:29PM +0200, Raed Salem wrote:
>> The inner_ipproto saves the inner IP protocol of the plain
>> text packet. This allows vendor's IPsec feature making offload
>> decision at skb's features_check and configuring hardware at
>> ndo_start_xmit, current code implenetation did not handle the
>> case where IPsec is used in tunnel mode.
>>
>> Fix by handling the case when IPsec is used in tunnel mode by
>> reading the protocol of the plain text packet IP protocol.
>>
>> Fixes: fa4535238fb5 ("net/xfrm: Add inner_ipproto into sec_path")
>> Signed-off-by: Raed Salem <raeds@...dia.com>
>
>Applied, thanks Raed!

hmm, there are two mlx5 patches that depend on this patch, I thought Raed
was planning to send them along with this.

Steffen, is it ok if I submit those two patches to you and so you would
send them all at once in your next net PR ?

Thanks,
Saeed.