lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YdsakgRku3ZgF77f@shredder> Date: Sun, 9 Jan 2022 19:25:38 +0200 From: Ido Schimmel <idosch@...sch.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote: > There are no legacy ports, DSA registers a devlink instance with ports > unconditionally for all switch drivers. Therefore, delete the old-style > ndo operations used for determining bridge forwarding domains. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Looks correct to me. If ndo_get_phys_port_name() is not implemented, then devlink_compat_phys_port_name_get() is called which invokes ndo_get_devlink_port() that you have implemented. Similarly, for ndo_get_port_parent_id(). Reviewed-by: Ido Schimmel <idosch@...dia.com>
Powered by blists - more mailing lists