netdev - Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto setting in sec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220110202028.ll3v2yy43gx37zih@sx1>
Date:   Mon, 10 Jan 2022 12:20:28 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     Raed Salem <raeds@...dia.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, kuba@...nel.org, huyn@...dia.com,
        saeedm@...dia.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto
 setting in sec_path

On Fri, Jan 07, 2022 at 12:03:06PM +0100, Steffen Klassert wrote:
>On Thu, Jan 06, 2022 at 04:47:26PM -0800, Saeed Mahameed wrote:
>> On Thu, Jan 06, 2022 at 10:32:23AM +0100, Steffen Klassert wrote:
>> > On Mon, Jan 03, 2022 at 01:19:29PM +0200, Raed Salem wrote:
>> > > The inner_ipproto saves the inner IP protocol of the plain
>> > > text packet. This allows vendor's IPsec feature making offload
>> > > decision at skb's features_check and configuring hardware at
>> > > ndo_start_xmit, current code implenetation did not handle the
>> > > case where IPsec is used in tunnel mode.
>> > >
>> > > Fix by handling the case when IPsec is used in tunnel mode by
>> > > reading the protocol of the plain text packet IP protocol.
>> > >
>> > > Fixes: fa4535238fb5 ("net/xfrm: Add inner_ipproto into sec_path")
>> > > Signed-off-by: Raed Salem <raeds@...dia.com>
>> >
>> > Applied, thanks Raed!
>>
>> hmm, there are two mlx5 patches that depend on this patch, I thought Raed
>> was planning to send them along with this.
>>
>> Steffen, is it ok if I submit those two patches to you and so you would
>> send them all at once in your next net PR ?
>
>The pull request with that patch included is already merged into
>the net tree. So if you pull the net tree, you can apply the
>mlx5 patches yourself. But if you prefer, I can take them too.
>

Didn't know they are already in net, i will post them to net soon,
thanks !