netdev - Re: [PATCH net-next v2 5/6] net: marvell: prestera: Register inetaddr stub notifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Jan 2022 03:00:12 +0200
From:   Yevhen Orlov <yevhen.orlov@...ision.eu>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org,
        stephen@...workplumber.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <tchornyi@...vell.com>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/6] net: marvell: prestera: Register
 inetaddr stub notifiers

On Fri, Jan 07, 2022 at 02:43:03PM +0100, Andrew Lunn wrote:
> On Fri, Jan 07, 2022 at 03:42:56AM +0200, Yevhen Orlov wrote:
> > On Thu, Dec 30, 2021 at 04:34:42PM +0200, Ido Schimmel wrote:
> > >
> > > What happens to that RIF when the port is linked to a bridge or unlinked
> > > from one?
> > >
> > 
> > We doesn't support any "RIF with bridge" scenario for now.
> > This restriction mentioned in cover latter.
> 
> I did not look at the code. Does it return -EOPNOTSUPP? And then
> bridging is performed by the host in software?
> 

Perhaps this is what you looking for:
> static int __prestera_inetaddr_event(struct prestera_switch *sw,
>                                 ┆    struct net_device *dev,
>                                 ┆    unsigned long event,
>                                 ┆    struct netlink_ext_ack *extack)
> {
>         if (!prestera_netdev_check(dev) || netif_is_bridge_port(dev) ||
>             netif_is_lag_port(dev) || netif_is_ovs_port(dev))
>                 return 0;

We just do nothing for bridge port.
Note: we cannot return ENOTSUPP here, because this will make
impossible to add address on bridge interface at all.