netdev - Re: [PATCH] bcmgenet: add WOL IRQ check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeCS6Ld93zCK6aWh@lunn.ch>
Date:   Thu, 13 Jan 2022 22:00:24 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] bcmgenet: add WOL IRQ check

On Thu, Jan 13, 2022 at 10:46:07PM +0300, Sergey Shtylyov wrote:
> The driver neglects to check the result of platform_get_irq_optional()'s
> call and blithely passes the negative error codes to devm_request_irq()
> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL.
> Stop calling devm_request_irq() with the invalid IRQ #s.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
> ---
> This patch is against DaveM's 'net.git' repo.

Since this is for net, it needs a Fixes: tag.

Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")

       Andrew