lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Jan 2022 13:37:42 -0800
From:   Florian Fainelli <>
To:     Andrew Lunn <>, Sergey Shtylyov <>
Cc:     Doug Berger <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,,
Subject: Re: [PATCH] bcmgenet: add WOL IRQ check

On 1/13/2022 1:00 PM, Andrew Lunn wrote:
> On Thu, Jan 13, 2022 at 10:46:07PM +0300, Sergey Shtylyov wrote:
>> The driver neglects to check the result of platform_get_irq_optional()'s
>> call and blithely passes the negative error codes to devm_request_irq()
>> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL.
>> Stop calling devm_request_irq() with the invalid IRQ #s.
>> Signed-off-by: Sergey Shtylyov <>
>> ---
>> This patch is against DaveM's 'net.git' repo.
> Since this is for net, it needs a Fixes: tag.
> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")

I don't have strong objections whether we want to consider this a bug 
fix or not, but since the code only acts upon devm_request_irq() 
returning 0 meaning success, this seems more like an improvement rather 
than fixing an actual issue.

Powered by blists - more mailing lists