lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Jan 2022 13:47:27 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, Sergey Shtylyov <s.shtylyov@....ru> Cc: Doug Berger <opendmb@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com Subject: Re: [PATCH] bcmgenet: add WOL IRQ check On 1/13/2022 1:37 PM, Florian Fainelli wrote: > > > On 1/13/2022 1:00 PM, Andrew Lunn wrote: >> On Thu, Jan 13, 2022 at 10:46:07PM +0300, Sergey Shtylyov wrote: >>> The driver neglects to check the result of platform_get_irq_optional()'s >>> call and blithely passes the negative error codes to devm_request_irq() >>> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL. >>> Stop calling devm_request_irq() with the invalid IRQ #s. >>> >>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru> >>> >>> --- >>> This patch is against DaveM's 'net.git' repo. >> >> Since this is for net, it needs a Fixes: tag. >> >> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt") > > I don't have strong objections whether we want to consider this a bug > fix or not, but since the code only acts upon devm_request_irq() > returning 0 meaning success, this seems more like an improvement rather > than fixing an actual issue. If you do repost, please subject your patch with "net: bcmgenet" for consistency with previous commits done to that file, and feel free to add: Acked-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists