netdev - Re: [PATCH net] ax25: use after free in ax25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fc4701f-c151-0545-c047-a5df90575d69@gmail.com>
Date:   Fri, 14 Jan 2022 07:19:56 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Hangyu Hua <hbh25y@...il.com>, jreuter@...na.de,
        ralf@...ux-mips.org, davem@...emloft.net, kuba@...nel.org
Cc:     linux-hams@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ax25: use after free in ax25_connect


On 1/13/22 22:54, Hangyu Hua wrote:
> Any suggestions for this patch ? Guys.
>
> I think putting sk_to_ax25 after lock_sock(sk) here will avoid any 
> possilbe race conditions like other functions in ax25_proto_ops. CTING) {
>

As explained, your patch is not needed.

You failed to describe how a race was possible.

Just moving code around wont help.

How about providing a stack trace or some syzbot repro ?