netdev - Re: [PATCH net] ax25: use after free in ax25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa1abfd4-e76b-f708-e2de-8018298ff07b@gmail.com>
Date:   Mon, 17 Jan 2022 09:35:10 +0800
From:   Hangyu Hua <hbh25y@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>, jreuter@...na.de,
        ralf@...ux-mips.org, davem@...emloft.net, kuba@...nel.org
Cc:     linux-hams@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ax25: use after free in ax25_connect

I get it.

Thanks.

On 2022/1/14 下午11:19, Eric Dumazet wrote:
> 
> On 1/13/22 22:54, Hangyu Hua wrote:
>> Any suggestions for this patch ? Guys.
>>
>> I think putting sk_to_ax25 after lock_sock(sk) here will avoid any 
>> possilbe race conditions like other functions in ax25_proto_ops. CTING) {
>>
> 
> As explained, your patch is not needed.
> 
> You failed to describe how a race was possible.
> 
> Just moving code around wont help.
> 
> How about providing a stack trace or some syzbot repro ?
>