lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Jan 2022 14:47:47 +0800 From: Kai-Heng Feng <kai.heng.feng@...onical.com> To: Jakub Kicinski <kuba@...nel.org> Cc: peppe.cavallaro@...com, alexandre.torgue@...s.st.com, joabreu@...opsys.com, "David S. Miller" <davem@...emloft.net>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Marek Behún <kabel@...nel.org>, Ivan Bornyakov <i.bornyakov@...rotek.ru>, Pali Rohár <pali@...nel.org>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware On Fri, Jan 14, 2022 at 12:35 PM Jakub Kicinski <kuba@...nel.org> wrote: > > On Fri, 14 Jan 2022 12:07:54 +0800 Kai-Heng Feng wrote: > > BIOS on Dell Edge Gateway 3200 already makes its own phy LED setting, so > > instead of setting another value, keep it untouched and restore the saved > > value on system resume. > > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com> > > I defer to PHY experts for review. Coincidentally the first Marvell > flag appears dead, nobody sets it: > > $ git grep MARVELL_PHY_M1145_FLAGS_RESISTANCE > drivers/net/phy/marvell.c: if (phydev->dev_flags & MARVELL_PHY_M1145_FLAGS_RESISTANCE) { > include/linux/marvell_phy.h:#define MARVELL_PHY_M1145_FLAGS_RESISTANCE 0x00000001 > $ > > unless it's read from DT under different name or something. It was introduced by 95d21ff4c645 without any user. Should we keep it? > > > Once you get some reviews please wait for net-next to open: > > http://vger.kernel.org/~davem/net-next.html > > and repost. It should happen the week of Jan 24th. When you repost > please drop the first patch, I believe Russell does not like the BIT() > macro, his opinion overrides checkpatch. Of course. I'll wait for the review and resubmit the 2nd patch. Kai-Heng > > Thanks!
Powered by blists - more mailing lists