lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Jan 2022 10:46:38 +0100 From: Alexander Stein <alexander.stein@...tq-group.com> To: Steve Glendinning <steve.glendinning@...well.net>, UNGLinuxDriver@...rochip.com, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Martyn Welch <martyn.welch@...labora.com>, Markus Reichl <m.reichl@...etechno.de> Cc: Markus Reichl <m.reichl@...etechno.de>, Gabriel Hojda <ghojda@...urs.ro>, netdev@...r.kernel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: usb: Correct reset handling of smsc95xx Hi Markus, Am Donnerstag, 13. Januar 2022, 21:01:11 CET schrieb Markus Reichl: > On boards with LAN9514 and no preconfigured MAC address we don't get an > ip address from DHCP after commit a049a30fc27c ("net: usb: Correct PHY > handling of smsc95xx") anymore. Adding an explicit reset before starting > the phy fixes the issue. > > [1] > https://lore.kernel.org/netdev/199eebbd6b97f52b9119c9fa4fd8504f8a34de18.came > l@...labora.com/ > > From: Gabriel Hojda <ghojda@...urs.ro> > Fixes: a049a30fc27c ("net: usb: Correct PHY handling of smsc95xx") > Signed-off-by: Gabriel Hojda <ghojda@...urs.ro> > Signed-off-by: Markus Reichl <m.reichl@...etechno.de> > --- > drivers/net/usb/smsc95xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c > index abe0149ed917..bc1e3dd67c04 100644 > --- a/drivers/net/usb/smsc95xx.c > +++ b/drivers/net/usb/smsc95xx.c > @@ -1962,7 +1962,8 @@ static const struct driver_info smsc95xx_info = { > .bind = smsc95xx_bind, > .unbind = smsc95xx_unbind, > .link_reset = smsc95xx_link_reset, > - .reset = smsc95xx_start_phy, > + .reset = smsc95xx_reset, > + .check_connect = smsc95xx_start_phy, > .stop = smsc95xx_stop, > .rx_fixup = smsc95xx_rx_fixup, > .tx_fixup = smsc95xx_tx_fixup, Tested-by: Alexander Stein <alexander.stein@...tq-group.com> This should go into stable-5.15! Tested on a TQMa6x on MBa6 which uses a SMSC9500 as a second ethernet interface. For the record: I noticed the problem as ARP replies were sent from the wrong interface. Thus my PC got the wrong MAC address which failed ping in the end. Best regards, Alexander
Powered by blists - more mailing lists