lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMuHMdWjo36UGde3g5ysdXpLJn=mrPp31SDODuQNPUqoc-ARrQ@mail.gmail.com> Date: Fri, 14 Jan 2022 10:58:51 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Sergey Shtylyov <s.shtylyov@....ru>, Mark Brown <broonie@...nel.org>, Andrew Lunn <andrew@...n.ch>, Ulf Hansson <ulf.hansson@...aro.org>, Vignesh Raghavendra <vigneshr@...com>, KVM list <kvm@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, linux-iio@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, Amit Kucheria <amitk@...nel.org>, ALSA Development Mailing List <alsa-devel@...a-project.org>, Jaroslav Kysela <perex@...ex.cz>, Guenter Roeck <groeck@...omium.org>, Thierry Reding <thierry.reding@...il.com>, MTD Maling List <linux-mtd@...ts.infradead.org>, Linux I2C <linux-i2c@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Miquel Raynal <miquel.raynal@...tlin.com>, linux-phy@...ts.infradead.org, netdev <netdev@...r.kernel.org>, linux-spi <linux-spi@...r.kernel.org>, Jiri Slaby <jirislaby@...nel.org>, Khuong Dinh <khuong@...amperecomputing.com>, Florian Fainelli <f.fainelli@...il.com>, Matthias Schiffer <matthias.schiffer@...tq-group.com>, Kamal Dasu <kdasu.kdev@...il.com>, Lee Jones <lee.jones@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Daniel Lezcano <daniel.lezcano@...aro.org>, Kishon Vijay Abraham I <kishon@...com>, "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, Zhang Rui <rui.zhang@...el.com>, platform-driver-x86@...r.kernel.org, Linux PWM List <linux-pwm@...r.kernel.org>, Robert Richter <rric@...nel.org>, Saravanan Sekar <sravanhome@...il.com>, Corey Minyard <minyard@....org>, Linux PM list <linux-pm@...r.kernel.org>, Liam Girdwood <lgirdwood@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, John Garry <john.garry@...wei.com>, Takashi Iwai <tiwai@...e.com>, Peter Korsgaard <peter@...sgaard.com>, William Breathitt Gray <vilhelm.gray@...il.com>, Mark Gross <markgross@...nel.org>, Hans de Goede <hdegoede@...hat.com>, Alex Williamson <alex.williamson@...hat.com>, Borislav Petkov <bp@...en8.de>, Jakub Kicinski <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, openipmi-developer@...ts.sourceforge.net, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Benson Leung <bleung@...omium.org>, Pengutronix Kernel Team <kernel@...gutronix.de>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, linux-edac@...r.kernel.org, Tony Luck <tony.luck@...el.com>, Richard Weinberger <richard@....at>, Mun Yew Tham <mun.yew.tham@...el.com>, Eric Auger <eric.auger@...hat.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Cornelia Huck <cohuck@...hat.com>, Linux MMC List <linux-mmc@...r.kernel.org>, Joakim Zhang <qiangqing.zhang@....com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, Vinod Koul <vkoul@...nel.org>, James Morse <james.morse@....com>, Zha Qipeng <qipeng.zha@...el.com>, Sebastian Reichel <sre@...nel.org>, Niklas Söderlund <niklas.soderlund@...natech.se>, linux-mediatek@...ts.infradead.org, Brian Norris <computersforpeace@...il.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Hi Uwe, On Thu, Jan 13, 2022 at 11:43 PM Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote: > On Thu, Jan 13, 2022 at 11:57:43PM +0300, Sergey Shtylyov wrote: > > On 1/13/22 11:17 PM, Mark Brown wrote: > > >> The subsystems regulator, clk and gpio have the concept of a dummy > > >> resource. For regulator, clk and gpio there is a semantic difference > > >> between the regular _get() function and the _get_optional() variant. > > >> (One might return the dummy resource, the other won't. Unfortunately > > >> which one implements which isn't the same for these three.) The > > >> difference between platform_get_irq() and platform_get_irq_optional() is > > >> only that the former might emit an error message and the later won't. > > > > This is only a current difference but I'm still going to return 0 ISO > > -ENXIO from latform_get_irq_optional(), no way I'd leave that -ENXIO there > > alone... :-) > > This would address a bit of the critic in my commit log. But as 0 isn't > a dummy value like the dummy values that exist for clk, gpiod and > regulator I still think that the naming is a bad idea because it's not > in the spirit of the other *_get_optional functions. > > Seeing you say that -ENXIO is a bad return value for > platform_get_irq_optional() and 0 should be used instead, I wonder why > not changing platform_get_irq() to return 0 instead of -ENXIO, too. > This question is for now only about a sensible semantic. That actually > changing platform_get_irq() is probably harder than changing > platform_get_irq_optional() is a different story. > > If only platform_get_irq_optional() is changed and given that the > callers have to do something like: > > if (this_irq_exists()): > ... (e.g. request_irq) > else: > ... (e.g. setup polling) > > I really think it's a bad idea that this_irq_exists() has to be > different for platform_get_irq() vs. platform_get_irq_optional(). For platform_get_irq(), the IRQ being absent is an error condition, hence it should return an error code. For platform_get_irq_optional(), the IRQ being absent is not an error condition, hence it should not return an error code, and 0 is OK. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists