lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <10cc73f1-53fd-9c5a-7fe2-8cd3786fbe37@arm.com> Date: Mon, 17 Jan 2022 21:32:55 +0000 From: German Gomez <german.gomez@....com> To: Ian Rogers <irogers@...gle.com> Cc: James Clark <james.clark@....com>, linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org, Chase Conklin <chase.conklin@....com>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Arnaldo Carvalho de Melo <acme@...hat.com>, Stephane Eranian <eranian@...gle.com>, netdev@...r.kernel.org, bpf@...r.kernel.org, "acme@...nel.org" <acme@...nel.org> Subject: Re: [PATCH] perf record/arm-spe: Override attr->sample_period for non-libpfm4 events Hi Ian, On 17/01/2022 16:28, Ian Rogers wrote: > [...] > Thanks for fixing this, I can add an acked-by for the v2 patch. Could > we add a test for this to avoid future regressions? There are similar > tests for frequency like: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/attr/test-record-freq > based on the attr.py test: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/attr.py > The test specifies a base type of event attribute and then what is > modified by the test. It takes a little to get your head around but > having a test for this would be a welcome addition. I agree I should have included a test for this fix. I'll look into this for the v2. Other events such as "-p 10000 -e cycles//" worked fine. Only the ones with aux area tracing (arm_spe, cs_etm, intel_pt) were ignoring the global config flags. Thank you for the pointers, and the review, German > > Thanks! > Ian > >> Thanks for the review, >> German
Powered by blists - more mailing lists