lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YeXo+G/roPb2G2rU@lunn.ch> Date: Mon, 17 Jan 2022 23:08:56 +0100 From: Andrew Lunn <andrew@...n.ch> To: Sergey Shtylyov <s.shtylyov@....ru> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, linux-renesas-soc@...r.kernel.org Subject: Re: [PATCH RFC] phy: make phy_set_max_speed() *void* On Tue, Jan 18, 2022 at 12:18:58AM +0300, Sergey Shtylyov wrote: > After following the call tree of phy_set_max_speed(), it became clear > that this function never returns anything but 0, so we can change its > result type to *void* and drop the result checks from the three drivers > that actually bothered to do it... > > Found by Linux Verification Center (linuxtesting.org) with the SVACE static > analysis tool. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru> Seems reasonable. net-next is closed at the moment, so please repost once it opens. Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists