netdev - Re: [PATCH RFC] phy: make phy_set_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e9a9558-e54f-9650-b4e2-fca4a4c2347b@omp.ru>
Date:   Tue, 18 Jan 2022 15:47:19 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "Russell King" <linux@...linux.org.uk>,
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH RFC] phy: make phy_set_max_speed() *void*

On 1/18/22 1:08 AM, Andrew Lunn wrote:

>> After following the call tree of phy_set_max_speed(), it became clear
>> that this function never returns anything but 0, so we can change its
>> result type to *void* and drop the result checks from the three drivers
>> that actually bothered to do it...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
> Seems reasonable.

   No need to seprate into severla patches? :-)

> net-next is closed at the moment, so please repost

   That's why RFC is mainly here. :-)

> once it opens.

   Sure.

> Reviewed-by: Andrew Lunn <andrew@...n.ch>

   T!

>     Andrew

MBR, Sergey