netdev - Re: [net-next RESEND v7 0/2] net: sched: allow user to select txqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jan 2022 09:33:02 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     netdev@...r.kernel.org
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexander Lobakin <alobakin@...me>,
        Paolo Abeni <pabeni@...hat.com>,
        Talal Ahmad <talalahmad@...gle.com>,
        Kevin Hao <haokexin@...il.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Kees Cook <keescook@...omium.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Antoine Tenart <atenart@...nel.org>,
        Wei Wang <weiwan@...gle.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [net-next RESEND v7 0/2] net: sched: allow user to select txqueue

On Fri, Jan 7, 2022 at 7:51 PM <xiangxia.m.yue@...il.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> Patch 1 allow user to select txqueue in clsact hook.
> Patch 2 support skbhash, classid, cpuid to select txqueue.
>
> Tonghao Zhang (2):
>   net: sched: use queue_mapping to pick tx queue
>   net: sched: support hash/classid/cpuid selecting tx queue
ping, any progress?
>  include/linux/netdevice.h              |  3 +
>  include/linux/rtnetlink.h              |  1 +
>  include/net/tc_act/tc_skbedit.h        |  1 +
>  include/uapi/linux/tc_act/tc_skbedit.h |  8 +++
>  net/core/dev.c                         | 31 +++++++++-
>  net/sched/act_skbedit.c                | 84 ++++++++++++++++++++++++--
>  6 files changed, 122 insertions(+), 6 deletions(-)
>
> --
> v7:
> * 1/2 fix build warn, move pick tx queue into egress_needed_key for
>   simplifing codes.
> v6:
> * 1/2 use static key and compiled when CONFIG_NET_EGRESS configured.
> v5:
> * 1/2 merge netdev_xmit_reset_txqueue(void),
>   netdev_xmit_skip_txqueue(void), to netdev_xmit_skip_txqueue(bool skip).
> v4:
> * 1/2 introduce netdev_xmit_reset_txqueue() and invoked in
>   __dev_queue_xmit(), so ximt.skip_txqueue will not affect
>   selecting tx queue in next netdev, or next packets.
>   more details, see commit log.
> * 2/2 fix the coding style, rename:
>   SKBEDIT_F_QUEUE_MAPPING_HASH -> SKBEDIT_F_TXQ_SKBHASH
>   SKBEDIT_F_QUEUE_MAPPING_CLASSID -> SKBEDIT_F_TXQ_CLASSID
>   SKBEDIT_F_QUEUE_MAPPING_CPUID -> SKBEDIT_F_TXQ_CPUID
> * 2/2 refactor tcf_skbedit_hash, if type of hash is not specified, use
>   the queue_mapping, because hash % mapping_mod == 0 in "case 0:"
> * 2/2 merge the check and add extack
> v3:
> * 2/2 fix the warning, add cpuid hash type.
> v2:
> * 1/2 change skb->tc_skip_txqueue to per-cpu var, add more commit message.
> * 2/2 optmize the codes.
>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Jonathan Lemon <jonathan.lemon@...il.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Alexander Lobakin <alobakin@...me>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Talal Ahmad <talalahmad@...gle.com>
> Cc: Kevin Hao <haokexin@...il.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Kumar Kartikeya Dwivedi <memxor@...il.com>
> Cc: Antoine Tenart <atenart@...nel.org>
> Cc: Wei Wang <weiwan@...gle.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> --
> 2.27.0
>


-- 
Best regards, Tonghao