netdev - Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jan 2022 07:19:04 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     cgel.zte@...il.com
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

On Tue, Jan 18, 2022 at 07:54:38AM +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from phy_read() directly instead
> of taking this in another redundant variable.

NAK this is purely cosmetic and not clearly better WRT CodingStyle.
 
> Reported-by: Zeal Robot <zealci@....com.cn>

Please make your robot less zealous or filter its results before
posting.

This is the second time I told you.  It isn't wise to ignore feedback,
and it is also rude.

Thanks,
Richard