netdev - Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220118091551.7aa44124@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 18 Jan 2022 09:15:51 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     cgel.zte@...il.com, Minghao Chi <chi.minghao@....com.cn>
Cc:     Richard Cochran <richardcochran@...il.com>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable

On Tue, 18 Jan 2022 07:19:04 -0800 Richard Cochran wrote:
> On Tue, Jan 18, 2022 at 07:54:38AM +0000, cgel.zte@...il.com wrote:
> > From: Minghao Chi <chi.minghao@....com.cn>
> > 
> > Return value from phy_read() directly instead
> > of taking this in another redundant variable.  
> 
> NAK this is purely cosmetic and not clearly better WRT CodingStyle.
>  
> > Reported-by: Zeal Robot <zealci@....com.cn>  
> 
> Please make your robot less zealous or filter its results before
> posting.

Plus what does it mean that the bot has signed this off?

> > Signed-off-by: CGEL ZTE <cgel.zte@...il.com>

> This is the second time I told you.  It isn't wise to ignore feedback,
> and it is also rude.

Same, you don't reply to emails and keep making the same mistakes.

I asked you to realign the continuation lines in:
https://lore.kernel.org/all/20220112083942.391fd0d7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net/
And without replying you just posted:
https://lore.kernel.org/all/20220118075159.925542-1-chi.minghao@zte.com.cn/