netdev - Re: [PATCH v22 bpf-next 17/23] bpf: selftests: update xdp_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yec90EIkR931IGwA@lore-desk>
Date:   Tue, 18 Jan 2022 23:23:12 +0100
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        lorenzo.bianconi@...hat.com, davem@...emloft.net, kuba@...nel.org,
        ast@...nel.org, daniel@...earbox.net, shayagr@...zon.com,
        john.fastabend@...il.com, dsahern@...nel.org, brouer@...hat.com,
        echaudro@...hat.com, jasowang@...hat.com,
        alexander.duyck@...il.com, saeed@...nel.org,
        maciej.fijalkowski@...el.com, magnus.karlsson@...el.com,
        tirthendu.sarkar@...el.com, toke@...hat.com
Subject: Re: [PATCH v22 bpf-next 17/23] bpf: selftests: update
 xdp_adjust_tail selftest to include multi-frags

> On Mon, Jan 17, 2022 at 06:28:29PM +0100, Lorenzo Bianconi wrote:
> > +
> > +	CHECK(err || retval != XDP_TX || size != exp_size,
> > +	      "9k-10b", "err %d errno %d retval %d[%d] size %d[%u]\n",
> > +	      err, errno, retval, XDP_TX, size, exp_size);
> ...
> > +	CHECK(err || retval != XDP_TX || size != exp_size,
> > +	      "9k-1p", "err %d errno %d retval %d[%d] size %d[%u]\n",
> > +	      err, errno, retval, XDP_TX, size, exp_size);
> ...
> > +	CHECK(err || retval != XDP_TX || size != exp_size,
> > +	      "9k-2p", "err %d errno %d retval %d[%d] size %d[%u]\n",
> > +	      err, errno, retval, XDP_TX, size, exp_size);
> 
> CHECK is deprecated.
> That nit was mentioned many times. Please address it in all patches.

I kept the CHECK macro because there were other CHECK occurrences in
xdp_adjust_tail.c (e.g. in test_xdp_adjust_tail_grow()).
I guess we can add a preliminary patch to convert the other CHECK
occurrences used in xdp_adjust_tail.c (the same for xdp_bpf2bpf.c).
What do you think?

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)