netdev - Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220119123657.51d3e027@hermes.local>
Date:   Wed, 19 Jan 2022 12:36:57 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Petr Machata <petrm@...dia.com>
Cc:     <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>,
        "Maksym Yaremchuk" <maksymy@...dia.com>
Subject: Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X
 default-prio"

On Tue, 18 Jan 2022 12:36:44 +0100
Petr Machata <petrm@...dia.com> wrote:

> +		} else if (matches(*argv, "default-prio") == 0) {
> +			dcb_app_print_default_prio(&tab);
>  		} else if (matches(*argv, "dscp-prio") == 0) {
>  			dcb_app_print_dscp_prio(dcb, &tab);

This is an example of why matches() sucks.

Existing users using:
   dcp app show dev X d
will now get different behavior.

You need to redo this patch and put the new argument after "dscp-pri"