lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jan 2022 12:43:56 -0800 From: Lucas De Marchi <lucas.demarchi@...el.com> To: Steven Rostedt <rostedt@...dmis.org> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, Emma Anholt <emma@...olt.net>, David Airlie <airlied@...ux.ie>, nouveau@...ts.freedesktop.org, Rasmus Villemoes <linux@...musvillemoes.dk>, dri-devel@...ts.freedesktop.org, Chris Wilson <chris@...is-wilson.co.uk>, Vishal Kulkarni <vishal@...lsio.com>, Francis Laniel <laniel_francis@...vacyrequired.com>, Kentaro Takeda <takedakn@...data.co.jp>, Mikita Lipski <mikita.lipski@....com>, amd-gfx@...ts.freedesktop.org, Andy Shevchenko <andy.shevchenko@...il.com>, Ben Skeggs <bskeggs@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Harry Wentland <harry.wentland@....com>, Petr Mladek <pmladek@...e.com>, Leo Li <sunpeng.li@....com>, intel-gfx@...ts.freedesktop.org, Raju Rangoju <rajur@...lsio.com>, Julia Lawall <julia.lawall@...6.fr>, Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Eryk Brol <eryk.brol@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, Christian König <christian.koenig@....com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, linux-security-module@...r.kernel.org, netdev@...r.kernel.org, Alex Deucher <alexander.deucher@....com>, Andrew Morton <akpm@...ux-foundation.org>, "David S . Miller" <davem@...emloft.net> Subject: Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: >On Wed, 19 Jan 2022 11:18:59 +0200 >Sakari Ailus <sakari.ailus@...ux.intel.com> wrote: > >> On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: >> > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, >> > case 3: >> > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) >> > tomoyo_io_printf(head, " grant_log=%s", >> > - tomoyo_yesno(cond->grant_log == >> > - TOMOYO_GRANTLOG_YES)); >> > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); >> >> This would be better split on two lines. > >Really? Yuck! > >I thought the "max line size" guideline was going to grow to a 100, but I >still see it as 80. But anyway... Checking that: docs still say 80, but checkpatch was changed to warn only on 100. Commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") is clear why the discrepancy. Lucas De Marchi > > cond->grant_log == > TOMOYO_GRANTLOG_YES > >is not readable at all. Not compared to > > cond->grant_log == TOMOYO_GRANTLOG_YES > >I say keep it one line! > >Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org> > >-- Steve > >> >> Then, >> >> Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com> >
Powered by blists - more mailing lists