lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jan 2022 12:53:43 -0800 From: Lucas De Marchi <lucas.demarchi@...el.com> To: Jani Nikula <jani.nikula@...ux.intel.com>, Petr Mladek <pmladek@...e.com>, linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org, linux-security-module@...r.kernel.org, nouveau@...ts.freedesktop.org, netdev@...r.kernel.org, Alex Deucher <alexander.deucher@....com>, Andrew Morton <akpm@...ux-foundation.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Ben Skeggs <bskeggs@...hat.com>, Christian König <christian.koenig@....com>, Chris Wilson <chris@...is-wilson.co.uk>, David Airlie <airlied@...ux.ie>, "David S . Miller" <davem@...emloft.net>, Emma Anholt <emma@...olt.net>, Eryk Brol <eryk.brol@....com>, Francis Laniel <laniel_francis@...vacyrequired.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Harry Wentland <harry.wentland@....com>, Jakub Kicinski <kuba@...nel.org>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Julia Lawall <julia.lawall@...6.fr>, Kentaro Takeda <takedakn@...data.co.jp>, Leo Li <sunpeng.li@....com>, Mikita Lipski <mikita.lipski@....com>, Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>, Raju Rangoju <rajur@...lsio.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Vishal Kulkarni <vishal@...lsio.com> Subject: Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: >On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: >> On Wed, 19 Jan 2022, Petr Mladek <pmladek@...e.com> wrote: >> > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> >> Add some helpers under lib/string_helpers.h so they can be used >> >> throughout the kernel. When I started doing this there were 2 other >> >> previous attempts I know of, not counting the iterations each of them >> >> had: >> >> >> >> 1) https://lore.kernel.org/all/20191023131308.9420-1-jani.nikula@intel.com/ >> >> 2) https://lore.kernel.org/all/20210215142137.64476-1-andriy.shevchenko@linux.intel.com/#t >> >> >> >> Going through the comments I tried to find some common ground and >> >> justification for what is in here, addressing some of the concerns >> >> raised. >> >> >> >> d. This doesn't bring onoff() helper as there are some places in the >> >> kernel with onoff as variable - another name is probably needed for >> >> this function in order not to shadow the variable, or those variables >> >> could be renamed. Or if people wanting <someprefix> >> >> try to find a short one >> > >> > I would call it str_on_off(). >> > >> > And I would actually suggest to use the same style also for >> > the other helpers. >> > >> > The "str_" prefix would make it clear that it is something with >> > string. There are other <prefix>_on_off() that affect some >> > functionality, e.g. mute_led_on_off(), e1000_vlan_filter_on_off(). >> > >> > The dash '_' would significantly help to parse the name. yesno() and >> > onoff() are nicely short and kind of acceptable. But "enabledisable()" >> > is a puzzle. >> > >> > IMHO, str_yes_no(), str_on_off(), str_enable_disable() are a good >> > compromise. >> > >> > The main motivation should be code readability. You write the >> > code once. But many people will read it many times. Open coding >> > is sometimes better than misleading macro names. >> > >> > That said, I do not want to block this patchset. If others like >> > it... ;-) >> >> I don't mind the names either way. Adding the prefix and dashes is >> helpful in that it's possible to add the functions first and convert >> users at leisure, though with a bunch of churn, while using names that >> collide with existing ones requires the changes to happen in one go. >> >> What I do mind is grinding this series to a halt once again. I sent a >> handful of versions of this three years ago, with inconclusive >> bikeshedding back and forth, eventually threw my hands up in disgust, >> and walked away. > >Yeah we can sed this anytime later we want to, but we need to get the foot >in the door. There's also a pile more of these all over. > >Acked-by: Daniel Vetter <daniel.vetter@...ll.ch> > >on the series, maybe it helps? And yes let's merge this through drm-misc. Ok, it seems we are reaching some agreement here then: - Change it to use str_ prefix - Wait -rc1 to avoid conflict - Merge through drm-misc I will re-send the series again soon. Lucas De Marchi
Powered by blists - more mailing lists