netdev - Re: tdc errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKa-r6teP-fL63MWZzEWfG4XzugN-dY4ZabNfTBubfetwDS-Rg@mail.gmail.com>
Date:   Fri, 21 Jan 2022 10:36:12 +0100
From:   Davide Caratti <dcaratti@...hat.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Victor Nogueira <victor@...atatu.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Simon Horman <simon.horman@...igine.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Buslov <vladbu@...dia.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: tdc errors

On Thu, Jan 20, 2022 at 8:34 PM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> On 2022-01-20 12:22, Victor Nogueira wrote:
> > Hi,
> >
> > When running these 2 tdc tests:
> >
> > 7d64 Add police action with skip_hw option
> > 3329 Validate flags of the matchall filter with skip_sw and
> > police action with skip_hw
> > I get this error:
> >
> > Bad action type skip_hw
> > Usage: ... gact <ACTION> [RAND] [INDEX]
> > Where: ACTION := reclassify | drop | continue | pass | pipe |
> > goto chain <CHAIN_INDEX> | jump <JUMP_COUNT>
> > RAND := random <RANDTYPE> <ACTION> <VAL>
> > RANDTYPE := netrand | determ
> > VAL : = value not exceeding 10000
> > JUMP_COUNT := Absolute jump from start of action list
> > INDEX := index value used
> >
> > I'm building the kernel on net-next.
> >
> > I'm compiling the latest iproute2 version.
> >
> > It seems like the problem is that support is lacking for skip_hw
> > in police action in iproute2.
> >
>
>
> So... How is the robot not reporting this as a regression?
> Davide? Basically kernel has the feature but code is missing
> in both iproute2 and iproute2-next..

my guess (but it's only a guess) is that also the tc-testing code is
less recent than the code of the kernel under test, so it does not not
contain new items (like 7d64).

But even if we had the latest net-next test code and the latest
net-next kernel under test, we would anyway see unstable test results,
because of the gap with iproute2 code.  My suggestion is to push new
tdc items (that require iproute2 bits, or some change to the kernel
configuration in the build environment) using 'skip: yes' in the JSON
(see [1]), and enable them only when we are sure that all the code
propagated at least to stable trees.

wdyt?

thanks!
-- 
davide

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=255c1c7279abf991