[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <74566284-ff3f-8e69-5b7d-d8ede75b78ad@gmail.com>
Date: Fri, 21 Jan 2022 11:18:09 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Marek BehĂșn <kabel@...nel.org>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
Cc: Vladimir Oltean <olteanv@...il.com>,
Holger Brunck <holger.brunck@...achienergy.com>,
Andrew Lunn <andrew@...n.ch>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Russell King <rmk+kernel@...linux.org.uk>,
linux-phy@...ts.infradead.org, Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt`
property binding
On 1/19/22 5:11 AM, Marek BehĂșn wrote:
> Common PHYs and network PCSes often have the possibility to specify
> peak-to-peak voltage on the differential pair - the default voltage
> sometimes needs to be changed for a particular board.
>
> Add properties `tx-p2p-microvolt` and `tx-p2p-microvolt-names` for this
> purpose. The second property is needed to specify the mode for the
> corresponding voltage in the `tx-p2p-microvolt` property, if the voltage
> is to be used only for speficic mode. More voltage-mode pairs can be
> specified.
>
> Example usage with only one voltage (it will be used for all supported
> PHY modes, the `tx-p2p-microvolt-names` property is not needed in this
> case):
>
> tx-p2p-microvolt = <915000>;
>
> Example usage with voltages for multiple modes:
>
> tx-p2p-microvolt = <915000>, <1100000>, <1200000>;
> tx-p2p-microvolt-names = "2500base-x", "usb", "pcie";
>
> Add these properties into a separate file phy/transmit-amplitude.yaml,
> which should be referenced by any binding that uses it.
p2p commonly means peer to peer which incidentally could be confusing,
can you spell out the property entire:
tx-peaktopeak-microvolt or:
tx-pk2pk-microvolt for a more compact name maybe?
--
Florian
Powered by blists - more mailing lists