netdev - Re: [PATCH net-next] sock: add sndbuff full perf trace event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ye234Pb0f1SusMbA@pop-os.localdomain>
Date:   Sun, 23 Jan 2022 12:17:36 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Joe Damato <jdamato@...tly.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net-next] sock: add sndbuff full perf trace event

On Thu, Jan 20, 2022 at 02:02:30PM -0800, Joe Damato wrote:
> Calls to sock_alloc_send_pskb can fail or trigger a wait if there is no
> sndbuf space available.
> 
> Add a perf trace event to help users monitor when and how this occurs so
> appropriate application level changes can be made, if necessary.
> 
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> ---
>  include/trace/events/sock.h | 21 +++++++++++++++++++++
>  net/core/sock.c             |  1 +
>  2 files changed, 22 insertions(+)

There are more places where we set the SOCKWQ_ASYNC_NOSPACE bit, so
it looks like your patch is incomplete.

Thanks.