lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220124075208.24c30dcc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Date: Mon, 24 Jan 2022 07:52:08 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Sasha Levin <sashal@...nel.org> Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>, "David S . Miller" <davem@...emloft.net>, tanghui20@...wei.com, netdev@...r.kernel.org Subject: Re: [PATCH AUTOSEL 5.16 12/19] net: apple: bmac: Fix build since dev_addr constification On Sat, 22 Jan 2022 19:11:05 -0500 Sasha Levin wrote: > From: Michael Ellerman <mpe@...erman.id.au> > > [ Upstream commit ea938248557a52e231a31f338eac4baee36a8626 ] > > Since commit adeef3e32146 ("net: constify netdev->dev_addr") the bmac > driver no longer builds with the following errors (pmac32_defconfig): > > linux/drivers/net/ethernet/apple/bmac.c: In function ‘bmac_probe’: > linux/drivers/net/ethernet/apple/bmac.c:1287:20: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)j)’ > 1287 | dev->dev_addr[j] = rev ? bitrev8(addr[j]): addr[j]; > | ^ > > Fix it by making the modifications to a local macaddr variable and then > passing that to eth_hw_addr_set(). > > We don't use the existing addr variable because the bitrev8() would > mutate it, but it is already used unreversed later in the function. Patches 11 and 12 are another case of prep for netdev->dev_addr being const in 5.17, we don't need those backported.
Powered by blists - more mailing lists