netdev - Re: [PATCH net 0/3] ethernet: fix some esoteric drivers after netdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220125162053.6d82aa8f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 25 Jan 2022 16:20:53 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>, dave@...dillows.org
Subject: Re: [PATCH net 0/3] ethernet: fix some esoteric drivers after
 netdev->dev_addr constification

On Wed, 26 Jan 2022 00:59:47 +0100 Arnd Bergmann wrote:
> > Hi Arnd, there's another case in drivers/net/ethernet/i825xx/ether1.c
> > which will be broken in 5.17, it looks like only RiscPC includes that.
> > But when I do:
> >
> > make ARCH=arm CROSS_COMPILE=$cross/arm-linux-gnueabi/bin/arm-linux-gnueabi- O=build_tmp/ rpc_defconfig
> >
> > The resulting config is not for ARCH_RPC:
> >
> > $ grep ARM_ETHER1 build_tmp/.config
> > $ grep RPC build_tmp/.config
> > # CONFIG_AF_RXRPC is not set
> > CONFIG_SUNRPC=y
> > # CONFIG_SUNRPC_DEBUG is not set
> > CONFIG_XZ_DEC_POWERPC=y
> > $ grep ACORN build_tmp/.config
> > # CONFIG_ACORN_PARTITION is not set
> > CONFIG_FONT_ACORN_8x8=y
> >
> > Is there an extra smidgen of magic I need to produce a working config
> > here?  Is RPC dead and can we send it off to Valhalla?  
> 
> Support for ARMv3 was removed in gcc-9, so there is a Kconfig
> dependency on the compiler version to prevent broken builds.
> You can use the gcc-8 builds from kernel.org[1].

That worked! Thank you!

> Russell still uses this machine with an older compiler though, and
> I guess he will keep using newer kernels for as long as gcc-8 can
> build them.
> 
> No idea which ethernet card he uses, there are at least three of them.
> 
> [1] https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.5.0/x86_64-gcc-8.5.0-nolibc-arm-linux-gnueabi.tar.gz

If there are 3 I broke the build for all of them, it seems :)
I'll send the fixes shortly.