netdev - Re: [PATCH net 1/3] ethernet: 3com/typhoon: don't write directly to netdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f37db63e287cf0f061c6a7ff1b53e4168d050c2c.camel@thedillows.org>
Date:   Tue, 25 Jan 2022 19:07:05 -0800
From:   David Dillow <dave@...dillows.org>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net 1/3] ethernet: 3com/typhoon: don't write directly to
 netdev->dev_addr

On Tue, 2022-01-25 at 14:23 -0800, Jakub Kicinski wrote:
> This driver casts off the const and writes directly to netdev-
> >dev_addr.
> This will result in a MAC address tree corruption and a warning.
> 
> Compile tested ppc6xx_defconfig.
> 
> Fixes: adeef3e32146 ("net: constify netdev->dev_addr")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks!

Acked-by: David Dillow <dave@...dillows.org>