netdev - RE: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5776C847D3EA30238E35CFD9FD219@MW4PR11MB5776.namprd11.prod.outlook.com>
Date:   Thu, 27 Jan 2022 19:48:15 +0000
From:   "Drewek, Wojciech" <wojciech.drewek@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dsahern@...il.com" <dsahern@...il.com>,
        "michal.swiatkowski@...ux.intel.com" 
        <michal.swiatkowski@...ux.intel.com>,
        "marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>
Subject: RE: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support

Hi Stephen,

I was just following the approach used for other options but it looks like that
JSON specific code is not needed. I 'll get rid of it in next version.

Regards,
Wojtek

> -----Original Message-----
> From: Stephen Hemminger <stephen@...workplumber.org>
> Sent: czwartek, 27 stycznia 2022 18:16
> To: Drewek, Wojciech <wojciech.drewek@...el.com>
> Cc: netdev@...r.kernel.org; dsahern@...il.com; michal.swiatkowski@...ux.intel.com; marcin.szycik@...ux.intel.com
> Subject: Re: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support
> 
> On Thu, 27 Jan 2022 14:13:55 +0100
> Wojciech Drewek <wojciech.drewek@...el.com> wrote:
> 
> > +	open_json_array(PRINT_JSON, name);
> > +	open_json_object(NULL);
> > +	print_uint(PRINT_JSON, "pdu_type", NULL, pdu_type);
> > +	print_uint(PRINT_JSON, "qfi", NULL, qfi);
> > +	close_json_object();
> > +	close_json_array(PRINT_JSON, name);
> > +
> > +	sprintf(strbuf, "%02x:%02x", pdu_type, qfi);
> 
> Doing JSON specific code is not necessary here?
> And why an array of two named elements? Seems confusing