netdev - RE: [PATCH iproute2-next 1/2] ip: GTP support in ip link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5776166C06742503C765BA2FFD219@MW4PR11MB5776.namprd11.prod.outlook.com>
Date:   Thu, 27 Jan 2022 19:52:26 +0000
From:   "Drewek, Wojciech" <wojciech.drewek@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dsahern@...il.com" <dsahern@...il.com>,
        "michal.swiatkowski@...ux.intel.com" 
        <michal.swiatkowski@...ux.intel.com>,
        "marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>
Subject: RE: [PATCH iproute2-next 1/2] ip: GTP support in ip link



> -----Original Message-----
> From: Stephen Hemminger <stephen@...workplumber.org>
> Sent: czwartek, 27 stycznia 2022 18:14
> To: Drewek, Wojciech <wojciech.drewek@...el.com>
> Cc: netdev@...r.kernel.org; dsahern@...il.com; michal.swiatkowski@...ux.intel.com; marcin.szycik@...ux.intel.com
> Subject: Re: [PATCH iproute2-next 1/2] ip: GTP support in ip link
> 
> On Thu, 27 Jan 2022 14:13:54 +0100
> Wojciech Drewek <wojciech.drewek@...el.com> wrote:
> 
> > +		if (role == GTP_ROLE_SGSN)
> > +			print_string(PRINT_ANY, "role", "role %s ", "sgsn");
> > +		else
> > +			print_string(PRINT_ANY, "role", "role %s ", "ggsn");
> 
> Why not us trigraph?
> 		print_string(PRINT_ANY, "role", "role %s ",
> 				role == GTP_ROLE_SGSN ? "sgsn" : "ggsn");
Just not a big fan of it, I'm not used to using it. It might look smooth here though.