netdev - Re: [PATCH wpan-next v2 3/5] net: mac802154: Convert the symbol duration into nanoseconds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ab159b2-b2f2-2442-0fba-cc6ec82cf397@datenfreihafen.org>
Date:   Fri, 28 Jan 2022 14:00:56 +0100
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Alexander Aring <alex.aring@...il.com>,
        linux-wpan@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Michael Hennerich <michael.hennerich@...log.com>,
        Varka Bhadram <varkabhadram@...il.com>,
        Xue Liu <liuxuenetmail@...il.com>, Alan Ott <alan@...nal11.us>
Subject: Re: [PATCH wpan-next v2 3/5] net: mac802154: Convert the symbol
 duration into nanoseconds


Hello.

On 28.01.22 12:08, Miquel Raynal wrote:
> Tdsym is often given in the spec as pretty small numbers in microseconds
> and hence was reflected in the code as symbol_duration and was stored as
> a u8. Actually, for UWB PHYs, the symbol duration is given in
> nanoseconds and are as precise as picoseconds. In order to handle better
> these PHYs, change the type of symbol_duration to u32 and store this
> value in nanoseconds.
> 
> All the users of this variable are updated in a mechanical way.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
>   drivers/net/ieee802154/at86rf230.c | 22 +++++++++++-----------
>   drivers/net/ieee802154/atusb.c     | 22 +++++++++++-----------
>   drivers/net/ieee802154/ca8210.c    |  2 +-
>   drivers/net/ieee802154/mcr20a.c    |  8 ++++----

I get a error on the mcr20a hunk when applying this. I assume its due to 
the mcr20a fix that hit wpan, but is not yet in wpan-next.

The wpan pull request for the fixes has been send today. Once merged and 
the next merge of net to net-next happened I will pull that in here to 
resolve the conflict.

regards
Stefan Schmidt