netdev - Re: [PATCH wpan-next v2 1/5] net: ieee802154: Improve the way supported channels are declared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB_54W60OiGmjLQ2dAvnraq6fkZ6GGTLMVzjVbVAobcvNsaWtQ@mail.gmail.com>
Date:   Sun, 30 Jan 2022 16:35:35 -0500
From:   Alexander Aring <alex.aring@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Stefan Schmidt <stefan@...enfreihafen.org>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Varka Bhadram <varkabhadram@...il.com>,
        Xue Liu <liuxuenetmail@...il.com>, Alan Ott <alan@...nal11.us>
Subject: Re: [PATCH wpan-next v2 1/5] net: ieee802154: Improve the way
 supported channels are declared

Hi,

On Fri, Jan 28, 2022 at 6:08 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
>
> The idea here is to create a structure per set of channels so that we
> can define much more than basic bitfields for these.
>
> The structure is currently almost empty on purpose because this change
> is supposed to be a mechanical update without additional information but
> more details will be added in the following commits.
>

In my opinion you want to put more information in this structure which
is not necessary and force the driver developer to add information
which is already there encoded in the page/channel bitfields. Why not
add helper functionality and get your "band" and "protocol" for a
page/channel combination?

- Alex