netdev - Re: [PATCH bpf-next] bpf, x86: remove unnecessary handling of BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61f357a749eef_738dc208ec@john.notmuch>
Date:   Thu, 27 Jan 2022 18:40:39 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Brendan Jackman <jackmanb@...gle.com>,
        Hou Tao <houtao1@...wei.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Martin KaFai Lau <kafai@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf, x86: remove unnecessary handling of BPF_SUB
 atomic op

Daniel Borkmann wrote:
> On 1/27/22 11:48 AM, Brendan Jackman wrote:
> > Yep - BPF_SUB is also excluded in Documentation/networking/filter.rst,
> > plus the interpreter and verifier don't support it.
> > 
> > Thanks,
> > 
> > Acked-by: Brendan Jackman <jackmanb@...gle.com>
> 
> I was wondering about verifier specifically as well. Added a note to the
> commit log that verifier rejects BPF_SUB while applying, thanks!
> 

Thanks for the follow up Hou/Brendan LGTM as well. After its been
merged, but ACK from me as well.