netdev - Re: [PATCH bpf-next] bpf, x86: remove unnecessary handling of BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0831a45-3d39-891b-b89c-36167421d28b@iogearbox.net>
Date:   Thu, 27 Jan 2022 22:51:07 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Brendan Jackman <jackmanb@...gle.com>, Hou Tao <houtao1@...wei.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Martin KaFai Lau <kafai@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf, x86: remove unnecessary handling of BPF_SUB
 atomic op

On 1/27/22 11:48 AM, Brendan Jackman wrote:
> Yep - BPF_SUB is also excluded in Documentation/networking/filter.rst,
> plus the interpreter and verifier don't support it.
> 
> Thanks,
> 
> Acked-by: Brendan Jackman <jackmanb@...gle.com>

I was wondering about verifier specifically as well. Added a note to the
commit log that verifier rejects BPF_SUB while applying, thanks!

> On Thu, 27 Jan 2022 at 09:17, Hou Tao <houtao1@...wei.com> wrote:
>>
>> According to the LLVM commit (https://reviews.llvm.org/D72184),
>> sync_fetch_and_sub() is implemented as a negation followed by
>> sync_fetch_and_add(), so there will be no BPF_SUB op and just
>> remove it.
>>
>> Signed-off-by: Hou Tao <houtao1@...wei.com>
>> ---
>>   arch/x86/net/bpf_jit_comp.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
>> index ce1f86f245c9..5d643ebb1e56 100644
>> --- a/arch/x86/net/bpf_jit_comp.c
>> +++ b/arch/x86/net/bpf_jit_comp.c
>> @@ -787,7 +787,6 @@ static int emit_atomic(u8 **pprog, u8 atomic_op,
>>          /* emit opcode */
>>          switch (atomic_op) {
>>          case BPF_ADD:
>> -       case BPF_SUB:
>>          case BPF_AND:
>>          case BPF_OR:
>>          case BPF_XOR:
>> --
>> 2.29.2
>>