[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87czkabjgo.fsf@waldekranz.com>
Date: Sat, 29 Jan 2022 17:22:15 +0100
From: Tobias Waldekranz <tobias@...dekranz.com>
To: Wei Yongjun <weiyongjun1@...wei.com>, weiyongjun1@...wei.com,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Marcin Wojtas <mw@...ihalf.com>,
Calvin Johnson <calvin.johnson@....nxp.com>,
Markus Koch <markus@...syncing.net>
Cc: netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH net-next] net/fsl: xgmac_mdio: fix return value check in
xgmac_mdio_probe()
On Sat, Jan 29, 2022 at 01:27, Wei Yongjun <weiyongjun1@...wei.com> wrote:
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should
> be replaced with NULL test.
>
> Fixes: 1d14eb15dc2c ("net/fsl: xgmac_mdio: Use managed device resources")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
Reviewed-by: Tobias Waldekranz <tobias@...dekranz.com>
Sorry about that. I started out by using devm_ioremap_resource, which
uses the in-band error signaling, and forgot to match the guard when I
changed it.
I see that this was reported by your CI, do you mind me asking what it
is running in the back-end? At least my version of sparse does not seem
to catch this.
Powered by blists - more mailing lists