lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 29 Jan 2022 17:22:15 +0100
From:   Tobias Waldekranz <>
To:     Wei Yongjun <>,,
        "David S. Miller" <>,
        Jakub Kicinski <>, Andrew Lunn <>,
        Marcin Wojtas <>,
        Calvin Johnson <>,
        Markus Koch <>
        Hulk Robot <>
Subject: Re: [PATCH net-next] net/fsl: xgmac_mdio: fix return value check in

On Sat, Jan 29, 2022 at 01:27, Wei Yongjun <> wrote:
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should
> be replaced with NULL test.
> Fixes: 1d14eb15dc2c ("net/fsl: xgmac_mdio: Use managed device resources")
> Reported-by: Hulk Robot <>
> Signed-off-by: Wei Yongjun <>

Reviewed-by: Tobias Waldekranz <>

Sorry about that. I started out by using devm_ioremap_resource, which
uses the in-band error signaling, and forgot to match the guard when I
changed it.

I see that this was reported by your CI, do you mind me asking what it
is running in the back-end? At least my version of sparse does not seem
to catch this.

Powered by blists - more mailing lists